fixed minor bug with mkswap in cc_disk_setup.py #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
approved these changes
Dec 24, 2019
|
Thank you so much for your contribution to cloud-init and for making cloud-init better! Contributions to cloud-init are governed by a Contributor License Agreement (CLA). Please confirm that you have signed the CLA per our hacking guide and run migrate-lp-user-to-github to associate this github account as someone who has signed the CLA. |
blackboxsw
added
the
CLA not signed
|
@blackboxsw, i thought we had a bot for that, i didn't realise you're the bot |
OddBloke
added
CLA signed
OddBloke
reviewed
Jan 7, 2020
Co-Authored-By: Daniel Watkins <daniel@daniel-watkins.co.uk>
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module cc_disk_setup.py fails when trying to initalize a swap partition with mkswap.
This is because 'lookup_force_flag' returns an empty string (''), which is taken as actual argument when launching mkswap , resulting in an error:
Unexpected error while running command.
Command: ['/usr/sbin/mkswap', '/dev/sdb', '']
Exit code: 1
Reason: -
Stdout:
Stderr: mkswap: invalid block count argument: ''
Preventing swap to work (this can be seen when using vmware hypervisor)
This patch simply remove the empty argument.